← Back to Bitcoin Improvement Proposals
BIPinformationalkey-management

BIP174: remove 'first byte is the type' comment for key data

As the key type is now defined as compact size integer, `At the beginning of each key is a compact size unsigned integer representing the type`, the comment in the first table in the document, about first byte of the key being the key type is no longer accurate. As the structure of the key data is described further in the text after the table, and the comment that it starts with the compact size integer seems a bit long to be in that table, I think it is better to just remove the comment about

No reviews
dgpv·Updated Dec 13, 2019·0 reviews·0 attestations·View source
Collections:BIPs — Merged

Specification

As the key type is now defined as compact size integer, At the beginning of each key is a compact size unsigned integer representing the type, the comment in the first table in the document, about first byte of the key being the key type is no longer accurate.

As the structure of the key data is described further in the text after the table, and the comment that it starts with the compact size integer seems a bit long to be in that table, I think it is better to just remove the comment about the key data structure from the table, and leave the explanation to the text after the table.

Discussion (0 threads)

Loading discussions...