← Back to Bitcoin Improvement Proposals
BIPinformationaltransactionssigning

Fix incorrect signature test vectors in BIP322

While attempting to implement bip322 I was unable to generate the same signature as the ones provided. Furthermore, I was unable to verify these signatures in my implementation. After some digging, I noticed the test vectors in the bip322 PR to Bitcoin Core uses different values. See util_tests.cpp in https://github.com/bitcoin/bitcoin/pull/24058 This P.R. replaces the current test vectors with the ones from the P.R. It also adds additional test vectors for the transaction hashes of the to_sp

No reviews
wip-abramson·Updated Nov 3, 2022·0 reviews·0 attestations·View source
Collections:BIPs — Merged

Specification

While attempting to implement bip322 I was unable to generate the same signature as the ones provided. Furthermore, I was unable to verify these signatures in my implementation. After some digging, I noticed the test vectors in the bip322 PR to Bitcoin Core uses different values.

See util_tests.cpp in https://github.com/bitcoin/bitcoin/pull/24058

This P.R. replaces the current test vectors with the ones from the P.R.

It also adds additional test vectors for the transaction hashes of the to_spend and to_sign transactions. Having these would have speeded up my debugging process significantly.

Discussion (0 threads)

Loading discussions...